Switch align APIs from Global to GVar. #515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/src/core/value/constant.jl b/src/core/value/constant.jl
index d81a3950..b9d6cc09 100644
--- a/src/core/value/constant.jl
+++ b/src/core/value/constant.jl
@@ -756,7 +756,7 @@ export GlobalValue, global_value_type,
visibility, visibility!,
dllstorage, dllstorage!,
unnamed_addr, unnamed_addr!,
- local_unnamed_addr, local_unnamed_addr!
+ local_unnamed_addr, local_unnamed_addr!
"""
parent(val::LLVM.GlobalValue)
@@ -893,8 +893,8 @@ export GlobalVariable, erase!,
isthreadlocal, threadlocal!,
threadlocalmode, threadlocalmode!,
isconstant, constant!,
- isextinit, extinit!,
- alignment, alignment!
+ isextinit, extinit!,
+ alignment, alignment!
"""
GlobalVariable <: LLVM.GlobalObject
diff --git a/test/core_tests.jl b/test/core_tests.jl
index 45b28c9a..c333b0c3 100644
--- a/test/core_tests.jl
+++ b/test/core_tests.jl
@@ -804,9 +804,9 @@ end
extinit!(gv, true)
@test isextinit(gv)
- @test alignment(gv) == 0
- alignment!(gv, 4)
- @test alignment(gv) == 4
+ @test alignment(gv) == 0
+ alignment!(gv, 4)
+ @test alignment(gv) == 4
@test threadlocalmode(gv) == LLVM.API.LLVMGeneralDynamicTLSModel
threadlocalmode!(gv, LLVM.API.LLVMNotThreadLocal) |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #515 +/- ##
=======================================
Coverage 87.88% 87.88%
=======================================
Files 45 45
Lines 2700 2700
=======================================
Hits 2373 2373
Misses 327 327
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows llvm/llvm-project#143188